[
https://issues.apache.org/jira/browse/CASSANDRA-8951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545513#comment-14545513
]
Aleksey Yeschenko commented on CASSANDRA-8951:
----------------------------------------------
Nice work. Very good coverage, too.
Attaching a diff with some minor changes:
- keeps {{byte}} a reserved type name in case we decide to add an unsigned byte
type later
- removed redundant @Override
- removed redundant code path in {{compare()}} methods, since we won't have
empty byte buffers in contexts where they'll be called
> Add smallint (and possibly byte) type
> -------------------------------------
>
> Key: CASSANDRA-8951
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8951
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Sylvain Lebresne
> Assignee: Benjamin Lerer
> Labels: client-impacting, docs-impacting, protocolv4
> Fix For: 2.2 beta 1
>
> Attachments: 8951-nits.txt
>
>
> We have {{int}} and {{bigint}}, but we don't have a {{smallint}} (2 bytes). I
> see no reason not to add it. And while we're at it, it doesn't cost much to
> add a {{byte}} type either.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
