[
https://issues.apache.org/jira/browse/CASSANDRA-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550496#comment-14550496
]
Ariel Weisberg commented on CASSANDRA-9369:
-------------------------------------------
If we were caught up and all tests were passing then yes disabling failing
tests would be a no-no. Right now when we are far behind and trying to catch up
it makes sense to disable tests we know aren't passing.
See CASSANDRA-8997 and CASSANDRA-9002 for why (and feel free to comment and
disagree).
Discussing this might be good retrospective fodder. I want to bring up the fact
that it's been a few months and utests and dtests still aren't passing, and
people are still doing feature work. What's the point of doing feature work for
a system that you can't ship anyways because the tests don't pass? I wouldn't
be surprised if the tests don't pass by the time we want to ship 2.2. By
branching 2.2 we increased test load an complexity because now we have two
places to merge to and two sets of tests to monitor.
I don't agree with the thinking that addressing test issues delays feature
work. It's already delayed you are just in denial.
> HSHA dtest for closing connections is failing on trunk
> ------------------------------------------------------
>
> Key: CASSANDRA-9369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9369
> Project: Cassandra
> Issue Type: Test
> Components: Tests
> Reporter: Tyler Hobbs
> Assignee: Ariel Weisberg
> Fix For: 2.2.x
>
>
> The {{thrift_hsha_test.ThriftHSHATest.test_closing_connections}} dtest is
> failing against trunk (but not against 2.1). Here's an example failure:
> {noformat}
> Error Message
> There are non-closed connections: COMMAND PID USER FD TYPE DEVICE
> SIZE/OFF NODE NAME
> java 28202 automaton 7u IPv4 60767 0t0 TCP
> localhost:58436->localhost:9160 (CLOSE_WAIT)
> -------------------- >> begin captured logging << --------------------
> dtest: DEBUG: cluster ccm directory: /tmp/dtest-U0pP7H
> dtest: DEBUG: Creating connection pools..
> dtest: DEBUG: Disabling/Enabling thrift iteration #0
> dtest: DEBUG: Closing connections from the client side..
> pycassa.pool: INFO: Pool 139721997822224 was disposed
> pycassa.pool: INFO: Pool 139721997714512 was disposed
> pycassa.pool: INFO: Pool 139721997749904 was disposed
> --------------------- >> end captured logging << ---------------------
> Stacktrace
> File "/usr/lib/python2.7/unittest/case.py", line 331, in run
> testMethod()
> File "/home/automaton/cassandra-dtest/thrift_hsha_test.py", line 59, in
> test_closing_connections
> self.assertEqual(len(lines), 0, "There are non-closed connections: %s" %
> stdout)
> File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
> assertion_func(first, second, msg=msg)
> File "/usr/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual
> raise self.failureException(msg)
> 'There are non-closed connections: COMMAND PID USER FD TYPE DEVICE
> SIZE/OFF NODE NAME\njava 28202 automaton 7u IPv4 60767 0t0 TCP
> localhost:58436->localhost:9160 (CLOSE_WAIT)\n\n-------------------- >> begin
> captured logging << --------------------\ndtest: DEBUG: cluster ccm
> directory: /tmp/dtest-U0pP7H\ndtest: DEBUG: Creating connection
> pools..\ndtest: DEBUG: Disabling/Enabling thrift iteration #0\ndtest: DEBUG:
> Closing connections from the client side..\npycassa.pool: INFO: Pool
> 139721997822224 was disposed\npycassa.pool: INFO: Pool 139721997714512 was
> disposed\npycassa.pool: INFO: Pool 139721997749904 was
> disposed\n--------------------- >> end captured logging <<
> ---------------------'
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
