[
https://issues.apache.org/jira/browse/CASSANDRA-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550640#comment-14550640
]
Ariel Weisberg commented on CASSANDRA-9369:
-------------------------------------------
I don't think committers checking in dtests that they then comment out is a
related issue? Disabling tests willy nilly is not something I am advocating. If
that is going on it's not acceptable and I'm going to complain about it at the
retrospective.
It's broken. We know it. There is no more information to be gleaned. If you
comment it out it has to be filed and assigned to someone who isn't going to
blow it off. If you broke it you fix it and you don't get to merge.
If we keep known failing tests around it obscures new failures and causes
people to commit broken code to trunk because they think it works since the
tests don't pass anyways. There is no mechanism for diffing your results
against trunk to see if your subset of failures is different.
If the button isn't blue people need to know it's their problem and they can't
blow it off until they have addressed every last failure (to meet whatever our
definition of addressed/done is). And they have to know that if the do sneak it
into trunk, ignoring the failure or not having submitted it to Cassci at all,
that it isn't cool.
> HSHA dtest for closing connections is failing on trunk
> ------------------------------------------------------
>
> Key: CASSANDRA-9369
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9369
> Project: Cassandra
> Issue Type: Test
> Components: Tests
> Reporter: Tyler Hobbs
> Assignee: Ariel Weisberg
> Fix For: 2.2.x
>
>
> The {{thrift_hsha_test.ThriftHSHATest.test_closing_connections}} dtest is
> failing against trunk (but not against 2.1). Here's an example failure:
> {noformat}
> Error Message
> There are non-closed connections: COMMAND PID USER FD TYPE DEVICE
> SIZE/OFF NODE NAME
> java 28202 automaton 7u IPv4 60767 0t0 TCP
> localhost:58436->localhost:9160 (CLOSE_WAIT)
> -------------------- >> begin captured logging << --------------------
> dtest: DEBUG: cluster ccm directory: /tmp/dtest-U0pP7H
> dtest: DEBUG: Creating connection pools..
> dtest: DEBUG: Disabling/Enabling thrift iteration #0
> dtest: DEBUG: Closing connections from the client side..
> pycassa.pool: INFO: Pool 139721997822224 was disposed
> pycassa.pool: INFO: Pool 139721997714512 was disposed
> pycassa.pool: INFO: Pool 139721997749904 was disposed
> --------------------- >> end captured logging << ---------------------
> Stacktrace
> File "/usr/lib/python2.7/unittest/case.py", line 331, in run
> testMethod()
> File "/home/automaton/cassandra-dtest/thrift_hsha_test.py", line 59, in
> test_closing_connections
> self.assertEqual(len(lines), 0, "There are non-closed connections: %s" %
> stdout)
> File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
> assertion_func(first, second, msg=msg)
> File "/usr/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual
> raise self.failureException(msg)
> 'There are non-closed connections: COMMAND PID USER FD TYPE DEVICE
> SIZE/OFF NODE NAME\njava 28202 automaton 7u IPv4 60767 0t0 TCP
> localhost:58436->localhost:9160 (CLOSE_WAIT)\n\n-------------------- >> begin
> captured logging << --------------------\ndtest: DEBUG: cluster ccm
> directory: /tmp/dtest-U0pP7H\ndtest: DEBUG: Creating connection
> pools..\ndtest: DEBUG: Disabling/Enabling thrift iteration #0\ndtest: DEBUG:
> Closing connections from the client side..\npycassa.pool: INFO: Pool
> 139721997822224 was disposed\npycassa.pool: INFO: Pool 139721997714512 was
> disposed\npycassa.pool: INFO: Pool 139721997749904 was
> disposed\n--------------------- >> end captured logging <<
> ---------------------'
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
