[
https://issues.apache.org/jira/browse/CASSANDRA-8568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553848#comment-14553848
]
Marcus Eriksson commented on CASSANDRA-8568:
--------------------------------------------
bq. LifecycleTransaction
yes, lets atleast do that. Regarding DataTracker -> Tracker, I guess it is
fine, but then everything mentioning DataTracker should be changed (for example
cfs.getDataTracker())
comments for updated branch:
* have you created a ticket for the failing ViewTest#testSSTablesInBounds() ?
(I guess this is the old-functionality-test you mention that is failing?)
* TrackerTest#testDropSSTables() seems to be failing due to the deleting task
being run before asserting the sizes (reducing the totalDiskSpaceUsed)
other than that, this looks good to me
> Impose new API on data tracker modifications that makes correct usage obvious
> and imposes safety
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-8568
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8568
> Project: Cassandra
> Issue Type: Bug
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 2.2.0 rc1
>
>
> DataTracker has become a bit of a quagmire, and not at all obvious to
> interface with, with many subtly different modifiers. I suspect it is still
> subtly broken, especially around error recovery.
> I propose piggy-backing on CASSANDRA-7705 to offer RAII (and GC-enforced, for
> those situations where a try/finally block isn't possible) objects that have
> transactional behaviour, and with few simple declarative methods that can be
> composed simply to provide all of the functionality we currently need.
> See CASSANDRA-8399 for context
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
