[
https://issues.apache.org/jira/browse/CASSANDRA-8568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554156#comment-14554156
]
Marcus Eriksson commented on CASSANDRA-8568:
--------------------------------------------
Just small nit that only happens when running unit tests:
{code}
java.lang.NullPointerException: name cannot be null
at javax.management.ObjectName.construct(ObjectName.java:421)
~[na:1.8.0_45]
at javax.management.ObjectName.<init>(ObjectName.java:1382)
~[na:1.8.0_45]
at
org.apache.cassandra.db.ColumnFamilyStore.unregisterMBean(ColumnFamilyStore.java:448)
~[Cassandra/:na]
at
org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:419)
~[Cassandra/:na]
at
org.apache.cassandra.db.lifecycle.TrackerTest.testDropSSTables(TrackerTest.java:193)
[Cassandra/:na]
at
org.apache.cassandra.db.lifecycle.TrackerTest.testDropSSTables(TrackerTest.java:177)
[Cassandra/:na]
...
{code}
other than that, I'm +1 once cassci finishes the tests
> Impose new API on data tracker modifications that makes correct usage obvious
> and imposes safety
> ------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-8568
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8568
> Project: Cassandra
> Issue Type: Bug
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 2.2.0 rc1
>
>
> DataTracker has become a bit of a quagmire, and not at all obvious to
> interface with, with many subtly different modifiers. I suspect it is still
> subtly broken, especially around error recovery.
> I propose piggy-backing on CASSANDRA-7705 to offer RAII (and GC-enforced, for
> those situations where a try/finally block isn't possible) objects that have
> transactional behaviour, and with few simple declarative methods that can be
> composed simply to provide all of the functionality we currently need.
> See CASSANDRA-8399 for context
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
