[
https://issues.apache.org/jira/browse/CASSANDRA-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569127#comment-14569127
]
Brandon Williams commented on CASSANDRA-9526:
---------------------------------------------
Thanks for the patch, Ron, this is good work.
A couple of nits here:
You disabled the logger.isTraceEnabled() in one call (which is fine) but then
repeated the pattern you undid thereafter. I can be fine with either since
they don't matter, but let's be consistent.
Your IDE incorrectly reordered the imports.
> Provide a JMX hook to monitor phi values in the FailureDetector
> ---------------------------------------------------------------
>
> Key: CASSANDRA-9526
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9526
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Ron Kuris
> Fix For: 2.0.x
>
> Attachments: Monitor-Phi-JMX.patch.txt,
> PHI-Log-Debug-When-Close.patch.txt, PHI-Race-Condition.patch.txt
>
>
> phi_convict_threshold can be tuned, but there's currently no way to monitor
> the phi values to see if you're getting close.
> The attached patch adds the ability to get these values via JMX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
