[
https://issues.apache.org/jira/browse/CASSANDRA-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569434#comment-14569434
]
Ron Kuris commented on CASSANDRA-9526:
--------------------------------------
Hi [~brandon.williams],
The rule I generally follow for checking logging levels is that if I actually
compute anything instead of just passing a reference to stuff, then I check the
logger level before making the call. This means I don't have to unnecessarily
compute anything to make the call, and the call short-circuits right away and
is nearly as cheap as checking outside the call. This pattern is documented in
the slf4j docs here: http://www.slf4j.org/faq.html#logging_performance
However, if you'd prefer consistency over this, I'd be glad to change it, just
say the word.
And, I'll fix the import reordering. Sometimes I hate IDEs.
> Provide a JMX hook to monitor phi values in the FailureDetector
> ---------------------------------------------------------------
>
> Key: CASSANDRA-9526
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9526
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Ron Kuris
> Fix For: 2.0.x
>
> Attachments: Monitor-Phi-JMX.patch.txt,
> PHI-Log-Debug-When-Close.patch.txt, PHI-Race-Condition.patch.txt
>
>
> phi_convict_threshold can be tuned, but there's currently no way to monitor
> the phi values to see if you're getting close.
> The attached patch adds the ability to get these values via JMX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
