[ 
https://issues.apache.org/jira/browse/CASSANDRA-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580894#comment-14580894
 ] 

Ariel Weisberg commented on CASSANDRA-9462:
-------------------------------------------

I found out why Benedict had to implement search for SSTableIntervalTree. 
IntervalTree relies on comparable for the bounds and nothing else so it doesn't 
know if the bounds are inclusive/exclusive.

Now whether SSTableIntervalTree needs to handle all the different kinds of 
bounds? Maybe that is a question still worth asking.

If that is the case, then the changes are basically fall out from me "fixing" 
the original SSTableIntervalTree search and adding tests for the methods and 
then making them consistent.

> ViewTest.sstableInBounds is failing
> -----------------------------------
>
>                 Key: CASSANDRA-9462
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9462
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>             Fix For: 3.x, 2.1.x, 2.2.x
>
>
> CASSANDRA-8568 introduced new tests to cover what was DataTracker 
> functionality in 2.1, and is now covered by the lifecycle package. This 
> particular test indicates this method does not fulfil the expected contract, 
> namely that more sstables are returned than should be.
> However while looking into it I noticed it also likely has a bug (which I 
> have not updated the test to cover) wherein a wrapped range will only yield 
> the portion at the end of the token range, not the beginning. It looks like 
> we may have call sites using this function that do not realise this, so it 
> could be a serious bug, especially for repair.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to