[ https://issues.apache.org/jira/browse/CASSANDRA-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611854#comment-14611854 ]
Sylvain Lebresne commented on CASSANDRA-9462: --------------------------------------------- I'll note that the new assertions of my patch have actually found what I think is a genuine bug in {{SizeEstimatesRecorder}} where it wasn't unwrapping the range (making it count only the size for the upper part of a wrapped range). I've pushed the simple fix on [the branch|https://github.com/pcmanus/cassandra/commits/9462]. > ViewTest.sstableInBounds is failing > ----------------------------------- > > Key: CASSANDRA-9462 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9462 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Benedict > Assignee: Ariel Weisberg > Fix For: 3.x, 2.1.x, 2.2.x > > > CASSANDRA-8568 introduced new tests to cover what was DataTracker > functionality in 2.1, and is now covered by the lifecycle package. This > particular test indicates this method does not fulfil the expected contract, > namely that more sstables are returned than should be. > However while looking into it I noticed it also likely has a bug (which I > have not updated the test to cover) wherein a wrapped range will only yield > the portion at the end of the token range, not the beginning. It looks like > we may have call sites using this function that do not realise this, so it > could be a serious bug, especially for repair. -- This message was sent by Atlassian JIRA (v6.3.4#6332)