[ 
https://issues.apache.org/jira/browse/CASSANDRA-9160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597886#comment-14597886
 ] 

Joshua McKenzie commented on CASSANDRA-9160:
--------------------------------------------

I'm fine with validation, though I think CQLTester should probably live in 
cql3/ rather than cql3/validation/util/

bq. it doesn't look 100% correct to me. It might still fail under heavy load
Could you elaborate and/or provide a scenario in which the current +1ms logic 
would fail under load on beginAndRepairPaxos? It's not immediately apparent to 
me but there's possibly more subtlety surrounding state at that time that I'm 
not familiar with.

Changes look good and the new structure is clear to me for both current tests 
and future categorization purposes.

2.1 applies cleanly, 2.2 needs a small rebase. Good to commit once we've gotten 
that sorted out.

> Migrate CQL dtests to unit tests
> --------------------------------
>
>                 Key: CASSANDRA-9160
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9160
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Sylvain Lebresne
>            Assignee: Stefania
>
> We have CQL tests in 2 places: dtests and unit tests. The unit tests are 
> actually somewhat better in the sense that they have the ability to test both 
> prepared and unprepared statements at the flip of a switch. It's also better 
> to have all those tests in the same place so we can improve the test 
> framework in only one place (CASSANDRA-7959, CASSANDRA-9159, etc...). So we 
> should move the CQL dtests to the unit tests (which will be a good occasion 
> to organize them better).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to