[
https://issues.apache.org/jira/browse/CASSANDRA-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Chia updated CASSANDRA-10003:
------------------------------------
Attachment: 0002-trunk-10003.patch
Actually, looking more carefully at the contract of
RowAndDeletionMergeIterator, it seems like it's intended to not return shadowed
data, and the flag there is really to optimize for cases where we know data
cannot be shadowed.
Updated the test to test this behavior better, and also added one more test
case to verify non-shadowed rows inside a range tombstone is correctly returned
still.
> RowAndDeletionMergeIteratorTest is failing on 3.0 and trunk
> -----------------------------------------------------------
>
> Key: CASSANDRA-10003
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10003
> Project: Cassandra
> Issue Type: Bug
> Reporter: Yuki Morishita
> Assignee: Daniel Chia
> Priority: Blocker
> Fix For: 3.0.x
>
> Attachments: 0001-trunk-10003.patch, 0002-trunk-10003.patch
>
>
> RowAndDeletionMergeIteratorTest is falling with the followings:
> {code}
> [junit] Testcase:
> testWithAtMostRangeTombstone(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
> FAILED
> [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
> [junit] junit.framework.AssertionFailedError: expected:<ROW> but
> was:<RANGE_TOMBSTONE_MARKER>
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithAtMostRangeTombstone(RowAndDeletionMergeIteratorTest.java:134)
> [junit]
> [junit]
> [junit] Testcase:
> testWithGreaterThanRangeTombstone(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
> FAILED
> [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
> [junit] junit.framework.AssertionFailedError: expected:<ROW> but
> was:<RANGE_TOMBSTONE_MARKER>
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithGreaterThanRangeTombstone(RowAndDeletionMergeIteratorTest.java:179)
> [junit]
> [junit]
> [junit] Testcase:
> testWithAtMostAndGreaterThanRangeTombstone(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
> FAILED
> [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
> [junit] junit.framework.AssertionFailedError: expected:<ROW> but
> was:<RANGE_TOMBSTONE_MARKER>
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithAtMostAndGreaterThanRangeTombstone(RowAndDeletionMergeIteratorTest.java:207)
> [junit]
> [junit]
> [junit] Testcase:
> testWithIncludingEndExcludingStartMarker(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
> FAILED
> [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
> [junit] junit.framework.AssertionFailedError: expected:<ROW> but
> was:<RANGE_TOMBSTONE_MARKER>
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithIncludingEndExcludingStartMarker(RowAndDeletionMergeIteratorTest.java:257)
> [junit]
> [junit]
> [junit] Testcase:
> testWithExcludingEndIncludingStartMarker(org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest):
> FAILED
> [junit] expected:<ROW> but was:<RANGE_TOMBSTONE_MARKER>
> [junit] junit.framework.AssertionFailedError: expected:<ROW> but
> was:<RANGE_TOMBSTONE_MARKER>
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.assertRow(RowAndDeletionMergeIteratorTest.java:328)
> [junit] at
> org.apache.cassandra.db.rows.RowAndDeletionMergeIteratorTest.testWithExcludingEndIncludingStartMarker(RowAndDeletionMergeIteratorTest.java:297)
> {code}
> cassci started to show the failure recently, but I can go back as far as
> {{2457599427d361314dce4833abeb5cd4915d0b06}} to see the failure on local.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
