[ 
https://issues.apache.org/jira/browse/CASSANDRA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977789#action_12977789
 ] 

Eric Evans commented on CASSANDRA-1710:
---------------------------------------

bq. returnConnection() possibly closes a connection and then returns the maybe 
closed connection back to the pool. Does this mean it is possible to borrow a 
closed connection?

Auh, right you are.  That block is missing a {{return}}.

{quote}
        •  it looks like the size of the pool can be artificially inflated by 
creating new Connections outside of the pool and then returning them to the 
pool.
        •  EvictionTask closes Connections that may already be closed. IIRC 
this will generate a Thrift exception when the transport is double-closed.
{quote}

Good catches.  v2 patches attached.

Thanks!

> Java driver for CQL
> -------------------
>
>                 Key: CASSANDRA-1710
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1710
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 0.8
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 
> v1-0001-CASSANDRA-1710-basic-connection-pooling-for-java-drive.txt, 
> v1-0002-compile-driver-source.txt, 
> v2-0001-CASSANDRA-1710-basic-connection-pooling-for-java-drive.txt, 
> v2-0002-compile-driver-source.txt
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> In-tree CQL drivers should be reasonably consistent with one another 
> (wherever possible/practical), and implement a minimum of:
> * Query compression
> * Keyspace assignment on connection
> * Connection pooling / load-balancing
> The goal is not to supplant the idiomatic libraries, but to provide a 
> consistent, stable base for them to build upon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to