[
https://issues.apache.org/jira/browse/CASSANDRA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729261#comment-14729261
]
Benedict commented on CASSANDRA-10220:
--------------------------------------
I have a patch up [here|https://github.com/belliottsmith/cassandra/tree/10220]
but I haven't looked at it in a couple of days, nor checked cassci closely and
compared with trunk.
There is some delicacy with the fact that the {{holder()}} requires {{build}}
to be called by the {{PartitionUpdate}} before being returned, which breaks
many users of it. For {{PartitionUpdate}} I felt this might be easy to
circumvent by just always returning {{metadata.partitionColumns()}} but I
haven't had time to properly think through the implications (but the patch I
have up does this).
You're more than welcome to adopt it, my version or not; if not, I'll take a
look at finishing it up tomorrow.
> Memtables do not handle column changes for their PartitionColumns
> -----------------------------------------------------------------
>
> Key: CASSANDRA-10220
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10220
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 3.0.0 rc1
>
>
> There are a couple of inherited issues around the {{PartitionColumns}} in
> {{AbstractBTreePartition}}. Firstly, we do not always return these columns,
> but sometimes the metadata columns. Secondly, the columns cannot be updated
> with new columns, and the metadata columns will not show dropped columns.
> This should most likely be moved into the {{Holder}}, and updated along with
> any other updates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
