[
https://issues.apache.org/jira/browse/CASSANDRA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730632#comment-14730632
]
Sylvain Lebresne commented on CASSANDRA-10220:
----------------------------------------------
For info, I've pushed a rebased version with 2 additional commits
[here|https://github.com/pcmanus/cassandra/commits/10220]. It does the
following changes to the original branch:
* when calling {{AbstractBTreePartition.unfilteredIterator(ColumnFilter
selection, ...)}}, the resulting iterator {{columns()}} was not returning the
original partition columns, even though it was guaranteed to only contain
columns from {{selection}} and hence calls would expect the iterator
{{columns()}} method to return either {{selection.fetchedColumns()}} or a
subset of it, which wasn't the case. I'll note that I don't know if this was
really manifesting as a bug, but I still think it's worth changing. Also, as I
mention in the commit, the ideal would be to take the intersection of the the
filter and the partition columns, but while that would be more precise, I don't
think we rely enough on such precision that it's worth making that computation.
* In {{AtomicBtreePartitions.addAllWithSizeDelta()}}, the columns from the
update were not merged with the existing ones, which I suspect was an oversight.
* For {{PartitionUpdate}}, the code actually passes the columns in the ctor
(and we even validate any added row does only has columns from this set), so I
think the right thing to do is just to return that and that's what the last
commit does.
I'll note that I appear to have been wrong about CASSANDRA-10169, this doesn't
seem to fix it. So I'll wait on CI to run on this branch before calling this
"ready for review" and I'll continue looking at CASSANDRA-10169 in the meantime.
> Memtables do not handle column changes for their PartitionColumns
> -----------------------------------------------------------------
>
> Key: CASSANDRA-10220
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10220
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Fix For: 3.0.0 rc1
>
>
> There are a couple of inherited issues around the {{PartitionColumns}} in
> {{AbstractBTreePartition}}. Firstly, we do not always return these columns,
> but sometimes the metadata columns. Secondly, the columns cannot be updated
> with new columns, and the metadata columns will not show dropped columns.
> This should most likely be moved into the {{Holder}}, and updated along with
> any other updates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
