[
https://issues.apache.org/jira/browse/CASSANDRA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734107#comment-14734107
]
Stefania commented on CASSANDRA-10066:
--------------------------------------
dtests look good.
Patch also looks good but I am not sure how to check with {{pep8}} so I simply
tried the following command on the 2.1 patch and I got errors other than line
too long (E501):
{code}
stefi@lila:~/git/cstar/cassandra/bin$ pep8 cqlsh | grep -v "E501"
cqlsh:109:1: E402 module level import not at top of file
cqlsh:110:1: E402 module level import not at top of file
cqlsh:111:1: E402 module level import not at top of file
cqlsh:112:1: E402 module level import not at top of file
cqlsh:113:1: E402 module level import not at top of file
cqlsh:114:1: E402 module level import not at top of file
cqlsh:122:1: E402 module level import not at top of file
cqlsh:123:1: E402 module level import not at top of file
cqlsh:125:1: E402 module level import not at top of file
cqlsh:127:1: E402 module level import not at top of file
cqlsh:128:1: E402 module level import not at top of file
cqlsh:1841:17: E731 do not assign a lambda expression, use a def
{code}
Are these errors expected or not?
> Bring cqlsh into PEP8 compliance
> --------------------------------
>
> Key: CASSANDRA-10066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10066
> Project: Cassandra
> Issue Type: Bug
> Reporter: Philip Thompson
> Assignee: Philip Thompson
> Priority: Minor
> Labels: cqlsh
> Fix For: 3.x, 2.1.x, 2.2.x
>
>
> In order for us to begin running flake8 against cqlsh.py in CI, it would be
> helpful if it were already PEP8 complaint, with the exception of using 120
> character lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
