[
https://issues.apache.org/jira/browse/CASSANDRA-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14747217#comment-14747217
]
Benedict commented on CASSANDRA-10351:
--------------------------------------
This does make me wonder if we named the methods badly, as nearly every use
case was {{write/readVInt}}, but should have been {{write/readUnsignedVInt}} -
I don't think a single use of the signed variety was warranted.
Patch available [here|https://github.com/belliottsmith/cassandra/tree/10351].
[~slebresne], would you like to review (since I think you did the initial
conversion)?
> We should use unsignedVInt, instead of VInt methods, for size serializations
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-10351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10351
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Priority: Trivial
> Fix For: 3.0.0 rc1
>
>
> It's not a huge deal, but it means we more rapidly use an extra byte, and
> just as importantly we also have more work to do to interpret the data. Since
> we do this a lot, we may as well keep it as efficient as possible for scalar
> values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
