[
https://issues.apache.org/jira/browse/CASSANDRA-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14747258#comment-14747258
]
Benedict commented on CASSANDRA-10351:
--------------------------------------
I've pushed a version with that addressed. I've got a follow up commit that
also reintroduces a message to {{writeUnsignedVInt}}, if you think it adds
informational value.
I've reverted {{IndexHelper}} - it's worth noting that we would have still
serialized negative values just fine, but in case anyone did do this they would
have incurred higher costs than we save by sticking with signed. Plus, it's
nice for signed encoding to have a purpose in life.
> We should use unsignedVInt, instead of VInt methods, for size serializations
> ----------------------------------------------------------------------------
>
> Key: CASSANDRA-10351
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10351
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Benedict
> Assignee: Benedict
> Priority: Trivial
> Fix For: 3.0.0 rc1
>
>
> It's not a huge deal, but it means we more rapidly use an extra byte, and
> just as importantly we also have more work to do to interpret the data. Since
> we do this a lot, we may as well keep it as efficient as possible for scalar
> values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
