[ 
https://issues.apache.org/jira/browse/CASSANDRA-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939108#comment-14939108
 ] 

Stefania commented on CASSANDRA-10421:
--------------------------------------

If we can have a transaction involving sstables located in different folders, 
or the txn log can end up in a totally different folder as it seems to be the 
case, then {{LogRecord.getExistingFiles()}} definitely needs to be fixed. 
However, we then have a bigger problem in listing temporary files, in that 
{{LogAwareFileLister}} assumes the txn log is located in the folder it is 
listing so we might miss temporary files when listing. We would have to either 
search for txn logs in multiple folders or pin them to a dedicated folder or 
enhance {{LogAwareFileLister}} to list all the sstable possible folders.

[~benedict] WDYT? 

> Potential issue with LogTransaction as it only checks in a single directory 
> for files
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10421
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10421
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Stefania
>
> When creating a new LogTransaction we try to create the new logfile in the 
> same directory as the one we are writing to, but as we use 
> {{[directories.getDirectoryForNewSSTables()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java#L125]}}
>  this might end up in "any" of the configured data directories. If it does, 
> we will not be able to clean up leftovers as we check for files in the same 
> directory as the logfile was created: 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LogRecord.java#L163
> cc [~Stefania]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to