[ 
https://issues.apache.org/jira/browse/CASSANDRA-10669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999900#comment-14999900
 ] 

Stefania commented on CASSANDRA-10669:
--------------------------------------

It's +1 but I think {{reader.descriptor.filenameFor(Component.DATA)}} should 
perhaps be {{reader.getFilename()}} at line 159 of SSTableRewriter.java. A bit 
more direct although both work.

Incidentally, the warning on a bad file descriptor has always been there, well 
at least for a while. It was only when CASSANDRA-9937 redirected the warnings 
of standalone tools to {{stderr}} that the tests started failing. However, at 
the time the tests were already failing for yet another reason and so it did 
not get noticed.

CI is here:

http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-marcuse-10669-testall/lastCompletedBuild/testReport/
http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-marcuse-10669-dtest/lastCompletedBuild/testReport/

It looks OK but we cannot verify the scrub dtests pass on Jenkins until the 
dtest pull request is merged. However I've checked locally and they pass.

> Scrub dtests are failing
> ------------------------
>
>                 Key: CASSANDRA-10669
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10669
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Sylvain Lebresne
>            Assignee: Marcus Eriksson
>             Fix For: 3.1
>
>
> A [bunch of scrub 
> dtest|http://cassci.datastax.com/job/cassandra-3.0_dtest/335/] have been 
> failing for a while. Looking at the history of one of those test, it used to 
> pass reliably but stopped working a while ago, and the changes when that 
> happened doesn't seem related from a quick glance. So maybe that's due to a 
> change in the dtest framework (maybe a ccm change even).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to