[
https://issues.apache.org/jira/browse/CASSANDRA-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011096#comment-15011096
]
Aleksey Yeschenko commented on CASSANDRA-9844:
----------------------------------------------
bq. and some other minor changes
Not a fan. This is not a code-style wiki, and many of these are going too far.
What we need is removal of the annoying ones, not adding even more. They are
just adding to the noise and hiding legit inspections. Can you please roll back
all the newly added ones, and additionally remove the following ones:
- lack of private constructor in a utility class. Annoying, provides no benefit
- {{public}} in interface method declarations - the team is split on this
issue, so there shouldn't be a warning
- "x" is an argument equalsIgnoreCase, instead of its target
- Method "x" can be static
- Pseudo functional style code (when using {{Iterables.filter}} and such)
- all of the 'Can be replaced with foreach/collect call' nonsense
Thanks
> Reevaluate inspections in generate-idea-files target
> ----------------------------------------------------
>
> Key: CASSANDRA-9844
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9844
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 3.x
>
>
> Current default inspections generated by the {{generate-idea-files}} ant
> target are generally fine.
> However there's room to improvement especially wrt Java8 lambda warnings that
> have (negative) performance impacts.
> So, this ticket is about to revisit all inspections wrt performance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
