[ 
https://issues.apache.org/jira/browse/CASSANDRA-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011173#comment-15011173
 ] 

Paulo Motta commented on CASSANDRA-7225:
----------------------------------------

Thanks for the feedback. Looks good overall. Some minor comments:
* Please fix broken links
** #counter -> #counters
** #usingdate -> #usingdates
* It's always opening "https://cassandra.apache.org/doc/"; because 
{{os.path.exists("file:///whatever")}} always returns False (you should 
probably remove the {{file://}} before verifying if it exist)
* HELP ASCII and HELP LIST are listed in "CQL help topics" but their help is on 
CQLSH, should they be listed as "Documented shell commands" instead?
* HELP TYPES shows help in both cqlsh and on the browser, should we keep just 
one of them?
* The default browser on debian (xdg-open) prints some strange characters on 
stderr, and there's no way to supress that on the webbrowser module:
{noformat}
cqlsh> help aggregates;
cqlsh> kioclient(4188) KMimeTypeRepository::parents: 
"/usr/share/mime/subclasses"  refers to unknown mimetype  
"application/vnd.ms-excel.sheet.binary.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  "application/vnd.ms-excel.addin.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  
"application/vnd.ms-powerpoint.slideshow.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  "application/vnd.ms-excel.sheet.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  
"application/vnd.ms-powerpoint.presentation.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  "application/vnd.ms-word.template.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  "application/vnd.ms-excel.template.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  
"application/vnd.ms-powerpoint.template.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  "application/vnd.ms-word.document.macroEnabled.12" 
kioclient(4188) KMimeTypeRepository::parents: "/usr/share/mime/subclasses"  
refers to unknown mimetype  
"application/vnd.ms-powerpoint.slide.macroEnabled.12"
{noformat}
I couldn't find alternatives to this problem. Should we at least provide a way 
to change the default browser on cqlshrc? If I switch to firefox this doesn't 
happen. We could maybe have "browser = default", and be able to change to 
"browser = firefox" via cqlshrc or options. It's possible to easily switch the 
browser on webbrowser module:
{{webbrowser.get(None).open_new_tab("https://cassandra.apache.org/doc/cql3/CQL-2.2.html#selectJson";)}}
 (None is the default, 'firefox' will open firefox, etc).

I'm not sure this will make to 3.1/3.0.1, since it's an improvement and not a 
bug fix, but on the other hand the documentation will become obsolete if we 
don't update there. Any thoughts [~iamaleksey]?

I will try on Windows and post the results later.

> cqlsh help for CQL3 is often incorrect and should be modernized
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-7225
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7225
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Documentation and Website, Tools
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Trivial
>              Labels: cqlsh
>             Fix For: 3.2, 2.2.x
>
>         Attachments: 7225-add-cql-docs-to-debian-package.patch, 
> 7225-cqlhelp.txt, EXPAND.pdf
>
>
> Just a small line of text in cqlsh "help" command indicates that < is <= and 
> > is >= in CQL.
> This is confusing to many people (including me :) ) because I did not expect 
> < to return the "equals" portion.
> Please allow distinct behaviours for <, <=, > and >= in CQL queries. Maybe in 
> combination with CASSANDRA-5184 and/or CASSANDRA-4914 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to