[ https://issues.apache.org/jira/browse/CASSANDRA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060307#comment-15060307 ]
Anubhav Kale commented on CASSANDRA-10580: ------------------------------------------ I am not sure what's going on with 2.2. I will look at it again today. I do the following to generate patches -- can you please confirm if that's what everyone follows ? 1. Change files 2. git status (Confirm that the changes are correct) 3. git add . 4. git commit -m "Foo" 5. git format-patch HEAD~ About the tests, I don't think the failures are related to my change. Are those failures expected ? > Add latency metrics for dropped messages > ---------------------------------------- > > Key: CASSANDRA-10580 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10580 > Project: Cassandra > Issue Type: Improvement > Components: Coordination, Observability > Environment: Production > Reporter: Anubhav Kale > Assignee: Anubhav Kale > Priority: Minor > Fix For: 3.2, 2.2.x > > Attachments: 0001-Metrics.patch, 10580-Metrics.patch, 10580.patch, > 2.2-All-Comments.patch, CASSANDRA-10580-Head.patch, Trunk-All-Comments.patch, > Trunk.patch > > > In our production cluster, we are seeing a large number of dropped mutations. > At a minimum, we should print the time the thread took to get scheduled > thereby dropping the mutation (We should also print the Message / Mutation so > it helps in figuring out which column family was affected). This will help > find the right tuning parameter for write_timeout_in_ms. > The change is small and is in StorageProxy.java and MessagingTask.java. I > will submit a patch shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)