[
https://issues.apache.org/jira/browse/CASSANDRA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060340#comment-15060340
]
Paulo Motta commented on CASSANDRA-10580:
-----------------------------------------
bq. can you please confirm if that's what everyone follows ?
You're generating patch correctly. I suspect you're not on the correct branch.
Is your cassandra-2.2 head b03ce9fd479d3da9c51d118c50480ea96df0d73e ?
If not, you need to synchronize your git repo with
https://github.com/apache/cassandra.git and checkout the latest cassandra-2.2
branch, and build your patch on the top of it.
bq. About the tests, I don't think the failures are related to my change. Are
those failures expected ?
I think they are unrelated too, they're in pair with main branch failures:
http://cassci.datastax.com/view/trunk/
> Add latency metrics for dropped messages
> ----------------------------------------
>
> Key: CASSANDRA-10580
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10580
> Project: Cassandra
> Issue Type: Improvement
> Components: Coordination, Observability
> Environment: Production
> Reporter: Anubhav Kale
> Assignee: Anubhav Kale
> Priority: Minor
> Fix For: 3.2, 2.2.x
>
> Attachments: 0001-Metrics.patch, 10580-Metrics.patch, 10580.patch,
> 2.2-All-Comments.patch, CASSANDRA-10580-Head.patch, Trunk-All-Comments.patch,
> Trunk.patch
>
>
> In our production cluster, we are seeing a large number of dropped mutations.
> At a minimum, we should print the time the thread took to get scheduled
> thereby dropping the mutation (We should also print the Message / Mutation so
> it helps in figuring out which column family was affected). This will help
> find the right tuning parameter for write_timeout_in_ms.
> The change is small and is in StorageProxy.java and MessagingTask.java. I
> will submit a patch shortly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
