[
https://issues.apache.org/jira/browse/CASSANDRA-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067144#comment-15067144
]
Paulo Motta commented on CASSANDRA-10866:
-----------------------------------------
Thanks for the patch. Some comments below:
- Please rebase to latest trunk.
- In {{MessagingService.updateDroppedMutationCount}} use
{{Keyspace.open(mutation.getKeyspaceName()).getColumnFamilyStore(UUID)}} to
fetch CFS instead of iterating in {{ColumnFamilyStore.all()}}, and also perform
null check if CFS is null (if table was dropped for example).
- In {{updateDroppedMutationCount(MessageIn message)}}, no need to check if
{{message.payload instanceof Collection<?>}}, since there are no
{{DROPPABLE_VERBS}} which operates on a collection of mutations.
- In {{StorageProxy.performLocally}}, add an {{Optional<Mutation>}} argument
that receives an {{Optional.absent(}} if it's not a mutation. Similarly,
{{LocalMutationRunnable}} should receive an {{Optional<Mutation>}} and only
count if {{!mutationOpt.isEmpty()}}
- In {{TableStats}} you removed the {{Maximum tombstones per slice}} metric by
mistake.
> Column Family should expose count metrics for dropped mutations.
> ----------------------------------------------------------------
>
> Key: CASSANDRA-10866
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10866
> Project: Cassandra
> Issue Type: Improvement
> Environment: PROD
> Reporter: Anubhav Kale
> Priority: Minor
> Attachments: 0001-CFCount.patch
>
>
> Please take a look at the discussion in CASSANDRA-10580. This is opened so
> that the latency on dropped mutations is exposed as a metric on column
> families.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
