[
https://issues.apache.org/jira/browse/CASSANDRA-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071771#comment-15071771
]
Paulo Motta commented on CASSANDRA-10866:
-----------------------------------------
Thanks for the patch. It's looking better. You'll need to print the
{{DroppedMutations}} metric in the {{TableStats}} command and verify it's being
correctly displayed in {{nodetool tablestats}} command. Also, on
{{LocalMutationRunnable}} you'll need to make the {{mutationOpt}} field is
final, and initialize it in the empty constructor (otherwise there will be
{{NullPointerException}}.
Some style nits:
* Remove {{updateDroppedMutationCount(MessageIn message)}} (since it's only
used once) and instead do the conditional {{message.payload instanceof
IMutation}} check on {{incrementDroppedMessages(MessageIn message, long
timeTaken)}} and call
{{updateDroppedMutationCount((IMutation)message.payload)}} from there.
* On {{LocalMutationRunnable}}, pass the optional to
{{MessagingService.incrementDroppedMutations}} and perform the conditional from
there.
* On {{updateDroppedMutationCount(IMutation mutation)}} replace the null
mutation check with an assertion, since it should never be null.
** Also no need to create the variable {{columnFamilyIds}}, you can iterate on
the loop directly on {{mutation.getColumnFamilyIds()}}.
* Use meaningful commit message
> Column Family should expose count metrics for dropped mutations.
> ----------------------------------------------------------------
>
> Key: CASSANDRA-10866
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10866
> Project: Cassandra
> Issue Type: Improvement
> Environment: PROD
> Reporter: Anubhav Kale
> Assignee: Anubhav Kale
> Priority: Minor
> Attachments: 0001-CFCount.patch, 10866-Trunk.patch
>
>
> Please take a look at the discussion in CASSANDRA-10580. This is opened so
> that the latency on dropped mutations is exposed as a metric on column
> families.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
