[
https://issues.apache.org/jira/browse/CASSANDRA-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111095#comment-15111095
]
Sam Tunnicliffe commented on CASSANDRA-10657:
---------------------------------------------
Looks good to me, in particular the liberal sprinkling of explanatory comments
re: fetching vs querying & #7085 is very welcome.
+1, with just minor nits:
In the javadoc for {{ColumnFilter}}:
* typo at the class level: "...and if a column has some sub-selction.."
* for {{selection(PartitionColumns columns)}} should read "A *filter* that only
fetches/queries the provided columns."
* for {{fetchedColumnIsQueried}} "\{@code fetches(columns) == true\}"
s/columns/column
* double }} in the javadoc for {{selectionBuilder()}} - the text doesn't quite
read right either
There are a few unused methods; I can't find any places which look like they
*should* be using these, so I guess they can be cleaned up (I could certainly
be missing something here though)
* {{ColumnFilter::fetches(Cell cell)}}
* {{SerializationHelper::fetchedStaticColumns}}
* {{SerializationHelper::fetchedRegularColumns}}
I won't mention the lack of tests, other than to say CASSANDRA-10531 is still
open & as mentioned there, this is all pretty well covered, indirectly at least.
> Re-enable/improve value skipping
> --------------------------------
>
> Key: CASSANDRA-10657
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10657
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 3.x
>
>
> This is a followup to CASSANDRA-10655, to re-enable the optimization of
> skipping values for the columns that are not requested by users in a CQL
> query. See CASSANDRA-10655 for why it was disabled, the goal here is to
> re-enable it minus the bugs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
