[
https://issues.apache.org/jira/browse/CASSANDRA-8616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145613#comment-15145613
]
Tyler Hobbs commented on CASSANDRA-8616:
----------------------------------------
The fix looks good to me as a temporary solution. However, I think you missed
a few tools that also need the fix:
* {{SSTableLevelResetter}}
* {{SSTableExpiredBlockers}}
* {{BulkLoader}}
And in later versions, we also need to fix:
* {{SSTableRepairedAtSetter}}
* {{StandaloneVerifier}}
* {{StandaloneSSTableUtil}}
As Sylvain mentions, it would be good to add regression dtests for these.
> sstable tools may result in commit log segments be written
> ----------------------------------------------------------
>
> Key: CASSANDRA-8616
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8616
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Reporter: Tyler Hobbs
> Assignee: Yuki Morishita
> Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
> Attachments: 8161-2.0.txt
>
>
> There was a report of sstable2json causing commitlog segments to be written
> out when run. I haven't attempted to reproduce this yet, so that's all I
> know for now. Since sstable2json loads the conf and schema, I'm thinking
> that it may inadvertently be triggering the commitlog code.
> sstablescrub, sstableverify, and other sstable tools have the same issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
