[
https://issues.apache.org/jira/browse/CASSANDRA-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173028#comment-15173028
]
Paulo Motta commented on CASSANDRA-11217:
-----------------------------------------
Overall LGTM, but how about moving the actual logging to {{DatabaseDescriptor}}
so we don't need to change the {{ConfigurationLoader}} interface and we'll also
log configuration of custom loaders? We could also maybe save the latest loaded
configuration and print only in case the configuration changed, since that
could still be useful to operators (though this will probably only happen when
refreshing seeds currently), WDYT?
The log {{INFO \[main\] 2016-02-29 21:59:21,025
YamlConfigurationLoader.java:92 - Loading settings from
file:~/.ccm/test/node1/conf/cassandra.yaml}} is still being print repeatedly,
should we maybe decrease the log level to {{DEBUG}}?
> Only log yaml config once, at startup
> -------------------------------------
>
> Key: CASSANDRA-11217
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11217
> Project: Cassandra
> Issue Type: Bug
> Components: Configuration, Core
> Reporter: Jason Brown
> Assignee: Jason Brown
> Priority: Minor
>
> CASSANDRA-6456 introduced a feature where the yaml is dumped in the log. At
> startup this is a nice feature, but I see that it’s actually triggered every
> time it handshakes with a node and fails to connect and the node happens to
> be a seed ([see
> here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L435]).
> Calling {{DD.getseeds()}} calls the {{SeedProvider}}, and if you happen to
> use {{SimpleSeedProvider}} it will reload the yaml config, and once again
> dump it out to the log.
> It's debatable if {{DD.getseeds()}} should trigger a reload (which I added in
> CASSANDRA-5459) or whether reloading the seeds should be a different method
> (it probably should), but we shouldn't keep logging the yaml config on every
> connection failure to a seed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
