[ https://issues.apache.org/jira/browse/CASSANDRA-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15174689#comment-15174689 ]
Jason Brown commented on CASSANDRA-11217: ----------------------------------------- bq. how about moving the actual logging to {{DatabaseDescriptor}} so we don't need to change the {{ConfigurationLoader}} Good call. I've moved the logging into {{Config#log}}, and is still invoked from DD the way it was in the first patch. bq. maybe decrease the log level to {{DEBUG}} Done. Tests running now. || 2.2 | 3.0 | trunk|| |[branch|https://github.com/jasobrown/cassandra/tree/config_logging_2.2]|[branch|https://github.com/jasobrown/cassandra/tree/config_logging_3.0]|[branch|https://github.com/jasobrown/cassandra/tree/config_logging_3.x] |[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_logging_2.2-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_logging_3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_logging_3.x-testall/] |[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_logging_2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_logging_3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_logging_3.x-dtest/] > Only log yaml config once, at startup > ------------------------------------- > > Key: CASSANDRA-11217 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11217 > Project: Cassandra > Issue Type: Bug > Components: Configuration, Core > Reporter: Jason Brown > Assignee: Jason Brown > Priority: Minor > > CASSANDRA-6456 introduced a feature where the yaml is dumped in the log. At > startup this is a nice feature, but I see that it’s actually triggered every > time it handshakes with a node and fails to connect and the node happens to > be a seed ([see > here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L435]). > Calling {{DD.getseeds()}} calls the {{SeedProvider}}, and if you happen to > use {{SimpleSeedProvider}} it will reload the yaml config, and once again > dump it out to the log. > It's debatable if {{DD.getseeds()}} should trigger a reload (which I added in > CASSANDRA-5459) or whether reloading the seeds should be a different method > (it probably should), but we shouldn't keep logging the yaml config on every > connection failure to a seed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)