[
https://issues.apache.org/jira/browse/CASSANDRA-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182983#comment-15182983
]
Marcus Eriksson commented on CASSANDRA-10805:
---------------------------------------------
it looks good, a few comments;
* timestamps on all log entries
* it could perhaps be useful to log if the compaction strategy handles repaired
or unrepaired data and which data directory it is handling instead of the
strategy id? Or perhaps log the mapping on startup so we can figure it out?
and a nit - remove redundant "this." in CompactionLogger.
And an idea - feel free to ignore, could we make the serialization 'pluggable'
in CompactionLogger? Then we could for example have all nodes in a cluster
write to a socket somewhere so that we don't have to ship log files to
visualize? We could do this in a followup ticket when/if anyone needs it though
> Additional Compaction Logging
> -----------------------------
>
> Key: CASSANDRA-10805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10805
> Project: Cassandra
> Issue Type: New Feature
> Components: Compaction, Observability
> Reporter: Carl Yeksigian
> Assignee: Carl Yeksigian
> Priority: Minor
>
> Currently, viewing the results of past compactions requires parsing the log
> and looking at the compaction history system table, which doesn't have
> information about, for example, flushed sstables not previously compacted.
> This is a proposal to extend the information captured for compaction.
> Initially, this would be done through a JMX call, but if it proves to be
> useful and not much overhead, it might be a feature that could be enabled for
> the compaction strategy all the time.
> Initial log information would include:
> - The compaction strategy type controlling each column family
> - The set of sstables included in each compaction strategy
> - Information about flushes and compactions, including times and all involved
> sstables
> - Information about sstables, including generation, size, and tokens
> - Any additional metadata the strategy wishes to add to a compaction or an
> sstable, like the level of an sstable or the type of compaction being
> performed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
