[ 
https://issues.apache.org/jira/browse/CASSANDRA-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184862#comment-15184862
 ] 

Marcus Eriksson commented on CASSANDRA-7019:
--------------------------------------------

* comment on Rows#removeShadowedCells needs updating
* in bde4c02cc858a900d43028b9a930e805ab232c27 there seems to be a few unrelated 
fixes (like the AbstractRow hashCode fix for example), should we break them out 
in a separate ticket? (so that we get them in 3.0 as well)
* why the FBUtilities.closeAll change? (going from Iterable<..> to List<..>)

I pushed a few small fixes 
[https://github.com/krummas/cassandra/commits/blambov/7019-with-nodetool-command|here]
 as well

And I think we need to test these scenarios;
* how does nodetool garbagecollect work if there are 1000+ sstables?
* run a repair on a vnode cluster with 100+GB (that usually creates a lot of 
sstables)

> Improve tombstone compactions
> -----------------------------
>
>                 Key: CASSANDRA-7019
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7019
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Marcus Eriksson
>            Assignee: Branimir Lambov
>              Labels: compaction
>             Fix For: 3.x
>
>
> When there are no other compactions to do, we trigger a single-sstable 
> compaction if there is more than X% droppable tombstones in the sstable.
> In this ticket we should try to include overlapping sstables in those 
> compactions to be able to actually drop the tombstones. Might only be doable 
> with LCS (with STCS we would probably end up including all sstables)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to