[
https://issues.apache.org/jira/browse/CASSANDRA-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184971#comment-15184971
]
Branimir Lambov commented on CASSANDRA-7019:
--------------------------------------------
Latest version
[here|https://github.com/blambov/cassandra/tree/blambov/7019-with-review], with
the extra logging removed and the comment updated. Let me know if you are OK
with it to squash and rebase.
bq. in bde4c02cc858a900d43028b9a930e805ab232c27 there seems to be a few
unrelated fixes (like the AbstractRow hashCode fix for example), should we
break them out in a separate ticket? (so that we get them in 3.0 as well)
The hashCode is the only fix there, extracted as CASSANDRA-11316. Another
commit has a slight improvement in
{{SizeTieredCompactionStrategy.getNextBackgroundSSTables}} which I don't think
is worth a separate ticket.
bq. why the FBUtilities.closeAll change? (going from Iterable<..> to List<..>)
I changed it from List to Iterable, but then realized I don't need it
(FileUtils has the right method) and reverted the change. Patch includes no
changes to FBUtilities.
> Improve tombstone compactions
> -----------------------------
>
> Key: CASSANDRA-7019
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7019
> Project: Cassandra
> Issue Type: Improvement
> Components: Compaction
> Reporter: Marcus Eriksson
> Assignee: Branimir Lambov
> Labels: compaction
> Fix For: 3.x
>
>
> When there are no other compactions to do, we trigger a single-sstable
> compaction if there is more than X% droppable tombstones in the sstable.
> In this ticket we should try to include overlapping sstables in those
> compactions to be able to actually drop the tombstones. Might only be doable
> with LCS (with STCS we would probably end up including all sstables)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
