[
https://issues.apache.org/jira/browse/CASSANDRA-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Knighton updated CASSANDRA-11168:
--------------------------------------
Status: Open (was: Patch Available)
The latest patch is pretty close - it just needs a few tweaks.
# It looks like the boolean condition around hintedHandoffEnabled() is inverted
- if we're moving all the following code inside the if, it should only be run
when hinted handoff is enabled, not the opposite.
# It looks like we still increment the metric when we decide not to hint
because hints are disabled for a specific datacenter. We shouldn't do this.
The version from your comment above doesn't have these problems; if you want me
to make a patch out of that, I can.
> Hint Metrics are updated even if hinted_hand-offs=false
> -------------------------------------------------------
>
> Key: CASSANDRA-11168
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11168
> Project: Cassandra
> Issue Type: Bug
> Reporter: Anubhav Kale
> Assignee: Anubhav Kale
> Priority: Minor
> Attachments: 0001-Hinted-Handoff-Fix.patch,
> 0001-Hinted-Handoff-fix-2_2.patch, 0001-Hinted-handoff-metrics.patch
>
>
> In our PROD logs, we noticed a lot of hint metrics even though we have
> disabled hinted handoffs.
> The reason is StorageProxy.ShouldHint has an inverted if condition.
> We should also wrap the if (hintWindowExpired) block in if
> (DatabaseDescriptor.hintedHandoffEnabled()).
> The fix is easy, and I can provide a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
