[
https://issues.apache.org/jira/browse/CASSANDRA-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joshua McKenzie updated CASSANDRA-11168:
----------------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.0.x)
(was: 2.2.x)
3.0.5
2.2.6
Status: Resolved (was: Ready to Commit)
[Committed|https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=719caa67649bf6f27cdd99dd7d6055d2aa8546ae],
with some whitespace and formatting fixes on the 3.0 patch.
> Hint Metrics are updated even if hinted_hand-offs=false
> -------------------------------------------------------
>
> Key: CASSANDRA-11168
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11168
> Project: Cassandra
> Issue Type: Bug
> Components: Coordination, Observability
> Reporter: Anubhav Kale
> Assignee: Anubhav Kale
> Priority: Minor
> Fix For: 2.2.6, 3.0.5, 3.5
>
> Attachments: 0001-Hinted-Handoff-Fix.patch,
> 0001-Hinted-Handoff-fix-2_2.patch, 0001-Hinted-handoff-metrics.patch,
> 0001-Hinted-handoffs-fix.patch
>
>
> In our PROD logs, we noticed a lot of hint metrics even though we have
> disabled hinted handoffs.
> The reason is StorageProxy.ShouldHint has an inverted if condition.
> We should also wrap the if (hintWindowExpired) block in if
> (DatabaseDescriptor.hintedHandoffEnabled()).
> The fix is easy, and I can provide a patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
