[ 
https://issues.apache.org/jira/browse/CASSANDRA-11344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195492#comment-15195492
 ] 

Paulo Motta commented on CASSANDRA-11344:
-----------------------------------------

bq. before it only summed up the total size of the sstables, now it gets an 
approximated expected compaction ratio.

nice catch. dtest look good now. I resubmitted CASSANDRA-9830 cstar runs to 
make sure results are still consistent with the new estimation. will mark this 
as ready to commit when that is finished and looks good.

as a minor style nit before committing, could you just move the compaction 
ratio estimation to a separate method so it doesn't crowd the 
{{MaxSSTableSizeWriter}} constructor?

> Fix bloom filter sizing with LCS
> --------------------------------
>
>                 Key: CASSANDRA-11344
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11344
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 2.2.x, 3.0.x, 3.x
>
>
> Since CASSANDRA-7272 we most often over allocate the bloom filter size with 
> LCS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to