[
https://issues.apache.org/jira/browse/CASSANDRA-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197735#comment-15197735
]
Joel Knighton commented on CASSANDRA-9692:
------------------------------------------
Some feedback from CI. I'll go into details since it is your first ticket so
forgive me if I bore you here. For Cassandra development, we have Cassandra
unit tests that live in-tree and distributed tests that live out-of-tree at
[riptano/cassandra-dtest|https://github.com/riptano/cassandra-dtest].
The in-tree unit tests look good compared to upstream:
[results|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-9692-trunk-testall/lastCompletedBuild/testReport/].
As expected, since the dtests are in Python and do lots by parsing logs, a few
failures have popped up: [dtest
results|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-9692-trunk-dtest/1/].
The {{resumable_bootstrap_test}} failure is unrelated. The other six are from
expecting log entries that were changed by this ticket.
If you'd like to fix these failures yourself. you can fork the [dtest
repository|https://github.com/riptano/cassandra-dtest] and create a branch with
these fixes. Once you've done so, link to the branch in a comment and I can run
CI against that dtest branch. We can then PR that branch to
riptano/cassandra-dtest at the same time this ticket gets merged.
If you'd rather not work with dtests for this ticket, I can do so. If you plan
on doing more Cassandra work, it might not be a bad idea to do the dtest
changes in this ticket to get more familiar with them.
> Print sensible units for all log messages
> -----------------------------------------
>
> Key: CASSANDRA-9692
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9692
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Benedict
> Assignee: Giampaolo
> Priority: Minor
> Labels: lhf
> Fix For: 3.x
>
> Attachments:
> Cassandra9692-Rev1-trunk-giampaolo-trapasso-at-radicalbit-io.diff,
> Cassandra9692-Rev2-trunk-giampaolo.trapasso-at-radicalbit-io.diff,
> Cassandra9692-trunk-giampaolo-trapasso-at-radicalbit-io.diff
>
>
> Like CASSANDRA-9691, this has bugged me too long. it also adversely impacts
> log analysis. I've introduced some improvements to the bits I touched for
> CASSANDRA-9681, but we should do this across the codebase. It's a small
> investment for a lot of long term clarity in the logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
