Edward Capriolo commented on CASSANDRA-10825:

Thanks. I am going to spend a little time here. In particular I want to be sure 
that inc() and dec() always happen. In particular now that this code path is 
active if we inc() and not dec() the system could keep throwing 
OverloadedException. Maybe the right answer is that the counter should decay 
over time or the count should be the OneMinuteRate or something along those 

> OverloadedException is untested
> -------------------------------
>                 Key: CASSANDRA-10825
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Ariel Weisberg
>            Assignee: Edward Capriolo
> If you grep test/src and cassandra-dtest you will find that the string 
> OverloadedException doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should 
> back-pressure and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test 
> that it is thrown under expected conditions. If there are behaviors driven by 
> catching or tracking OverloadedException we should test those as well.

This message was sent by Atlassian JIRA

Reply via email to