Edward Capriolo commented on CASSANDRA-10825:

[~tjake] [~iamaleksey] Thanks for looking. Before I rebase for two branches I 
made some minor changes.

* Switched from AtomicLong to counter
* Move the structure into the StorageMetrics class
* During the exception captured the stats to method variables, the way it was 
written there is moments of time between data collection and message printing

Let me know if you like these changes.

> OverloadedException is untested
> -------------------------------
>                 Key: CASSANDRA-10825
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Ariel Weisberg
>            Assignee: Edward Capriolo
> If you grep test/src and cassandra-dtest you will find that the string 
> OverloadedException doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should 
> back-pressure and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test 
> that it is thrown under expected conditions. If there are behaviors driven by 
> catching or tracking OverloadedException we should test those as well.

This message was sent by Atlassian JIRA

Reply via email to