[
https://issues.apache.org/jira/browse/CASSANDRA-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15668258#comment-15668258
]
Tyler Hobbs commented on CASSANDRA-10145:
-----------------------------------------
Thanks for the patch, [~stamhankar999]. Overall I think it's pretty good, I
just have a couple of review comments:
* As you commented in {{native_protocol_v5.spec}}, we can go with a {{<flags>}}
field after the query string in {{PREPARE}} messages. That would be more in
line with how we handle optional fields in other messages.
* We should probably rename {{ClientState.withKeyspace()}} to
{{maybeOverrideWithKeyspaceFromOptions()}}, and update the javadoc to clarify
the behavior when null is passed in.
* I'm not sure that I fully follow your comment in {{CFStatement}}. If you
think you can make a clear improvement around that behavior, would you mind
making a separate patch with those changes for me to take a look at?
Besides that, I think everything else looks good so far. After you made the
above changes, I'll set up CI test runs.
> Change protocol to allow sending key space independent of query string
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-10145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10145
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Vishy Kasar
> Assignee: Sandeep Tamhankar
> Fix For: 3.x
>
> Attachments: 10145-trunk.txt
>
>
> Currently keyspace is either embedded in the query string or set through "use
> keyspace" on a connection by client driver.
> There are practical use cases where client user has query and keyspace
> independently. In order for that scenario to work, they will have to create
> one client session per keyspace or have to resort to some string replace
> hackery.
> It will be nice if protocol allowed sending keyspace separately from the
> query.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
