[
https://issues.apache.org/jira/browse/CASSANDRA-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938545#comment-15938545
]
Sylvain Lebresne commented on CASSANDRA-13340:
----------------------------------------------
bq. Previous block sometimes means the next we'll iterate to (previous on
disk), other times the previous we iterated.
You're right, that's confusing. That said, I tried switching the newly
introduced {{hasPrevious/NextBlock}} but at least to me that felt pretty
confusing, so I decide to switch the existing usage. Basically feels more
logical to me, though that's possibly somewhat personal. In any case it's
consistent now, previous/next refer to the previous/next block we'll iterate.
bq. {{skipLast/First}} have the same problem
If you mean that first/last can be a tad confused when we're reading a block in
one sense but iterating on its items afterward in the other sense, then I
agree, but I didn't felt inverting those was really improving things. I did
added {{IteratedItem}} and completed the comments so it's hopefully more clear.
bq. but {{readCurrentBlock}} can do without the latter, can't it?
Absolutely, removed the redundant argument, thanks.
> Bugs handling range tombstones in the sstable iterators
> -------------------------------------------------------
>
> Key: CASSANDRA-13340
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13340
> Project: Cassandra
> Issue Type: Bug
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 3.0.x, 3.11.x
>
>
> There is 2 bugs in the way sstable iterators handle range tombstones:
> # empty range tombstones can be returned due to a strict comparison that
> shouldn't be.
> # the sstable reversed iterator can actually return completely bogus results
> when range tombstones are spanning multiple index blocks.
> The 2 bugs are admittedly separate but as they both impact the same area of
> code and are both range tombstones related, I suggest just fixing both here
> (unless something really really mind).
> Marking the ticket critical mostly for the 2nd bug: it can truly make use
> return bad results on reverse queries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
