[
https://issues.apache.org/jira/browse/CASSANDRA-13340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938583#comment-15938583
]
Branimir Lambov commented on CASSANDRA-13340:
---------------------------------------------
LGTM
Nit: there are a few more inverted meanings: [in these two
comments|https://github.com/pcmanus/cassandra/blob/94c0a9cca6b072e5f35c666c56e7ad1eb0577e7c/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java#L189]
as well as [this
{{lastOfPrevious}}|https://github.com/pcmanus/cassandra/blob/94c0a9cca6b072e5f35c666c56e7ad1eb0577e7c/src/java/org/apache/cassandra/db/columniterator/SSTableReversedIterator.java#L352].
> Bugs handling range tombstones in the sstable iterators
> -------------------------------------------------------
>
> Key: CASSANDRA-13340
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13340
> Project: Cassandra
> Issue Type: Bug
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Critical
> Fix For: 3.0.x, 3.11.x
>
>
> There is 2 bugs in the way sstable iterators handle range tombstones:
> # empty range tombstones can be returned due to a strict comparison that
> shouldn't be.
> # the sstable reversed iterator can actually return completely bogus results
> when range tombstones are spanning multiple index blocks.
> The 2 bugs are admittedly separate but as they both impact the same area of
> code and are both range tombstones related, I suggest just fixing both here
> (unless something really really mind).
> Marking the ticket critical mostly for the 2nd bug: it can truly make use
> return bad results on reverse queries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)