[
https://issues.apache.org/jira/browse/CASSANDRA-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966963#comment-15966963
]
Sandeep Tamhankar commented on CASSANDRA-10145:
-----------------------------------------------
[~jjirsa] These are interesting points! Here are my thoughts on them:
* PrepareMessage constructor: I'm not married to what I did there, but my
thinking for adding a required arg was, "I want callers to think through their
scenario when they instantiate a PrepareMessage. Maybe they have a keyspace
name, so they should pass it along." I felt that making two constructors made
it too easy to introduce a bug where keyspace-name could get lost in some code
path.
* Woops on violating the style guide. In general, I tried to follow the style
of other code, but I guess I missed something here (or I copied the form of
some other code that also violates the style guide.)
* Agree totally that it would be better to replace that ternary with an if.
> Change protocol to allow sending key space independent of query string
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-10145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10145
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Vishy Kasar
> Assignee: Sandeep Tamhankar
> Labels: client-impacting, protocolv5
> Fix For: 4.0
>
> Attachments: 10145-trunk.txt
>
>
> Currently keyspace is either embedded in the query string or set through "use
> keyspace" on a connection by client driver.
> There are practical use cases where client user has query and keyspace
> independently. In order for that scenario to work, they will have to create
> one client session per keyspace or have to resort to some string replace
> hackery.
> It will be nice if protocol allowed sending keyspace separately from the
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
