[
https://issues.apache.org/jira/browse/CASSANDRA-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028122#comment-16028122
]
Marcus Eriksson commented on CASSANDRA-13068:
---------------------------------------------
Had a quick read through, and we really need tests for the disk space stuff, I
added one here: https://github.com/krummas/cassandra/commits/lerh/13068 - maybe
you could add a few more testing this feature?
just a single code comment so far, in
{{CompactionTask#reduceScopeForLimitedSpace}} - no need to do
{{nonExpiredSSTables.remove(removedSSTable);}} - {{nonExpiredSSTables}} is
{{Sets.difference(transaction.originals(),
controller.getFullyExpiredSSTables());}} so when you cancel the sstable from
the transaction, it gets removed from {{nonExpiredSSTables}} (otherwise it
would have thrown an exception since {{Sets.difference}} returns an
unmodifiable set)
I'll do a deeper code review once the tests are in
> Fully expired sstable not dropped when running out of disk space
> ----------------------------------------------------------------
>
> Key: CASSANDRA-13068
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13068
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
> Reporter: Marcus Eriksson
> Assignee: Lerh Chuan Low
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> If a fully expired sstable is larger than the remaining disk space we won't
> run the compaction that can drop the sstable (ie, in our disk space check
> should not include the fully expired sstables)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
