[
https://issues.apache.org/jira/browse/CASSANDRA-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047380#comment-16047380
]
Krishna Dattu Koneru commented on CASSANDRA-13068:
--------------------------------------------------
Hi [~krummas] , I work with [~Lerh Low] . He wanted me to continue working on
this. I have uploaded patches on github for [trunk|
https://github.com/apache/cassandra/compare/trunk...krishna-koneru:cassandra-trunk-13068
] and [3.11 |
https://github.com/apache/cassandra/compare/cassandra-3.11...krishna-koneru:cassandra-3.11-13068]
branches .
I had to make few more changes to what was initially implemented by [~Lerh Low]
to address your comments.
- renamed {{CompactionTask#checkAvailableDiskSpace()}} to
{{CompactionTask#buildCompactionCandidatesForAvailableDiskSpace()}} as the
method checks and might also modify the list of SSTables that will be compacted.
- {{buildCompactionCandidatesForAvailableDiskSpace()}} does not throw exception
if there is no diskspace to compact non-expired SSTables when there are fully
expired SSTables.This means, instead of throwing exception, we try to compact
fully expired SSTables which might free up some space to allow further
compactions.
> Fully expired sstable not dropped when running out of disk space
> ----------------------------------------------------------------
>
> Key: CASSANDRA-13068
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13068
> Project: Cassandra
> Issue Type: Bug
> Components: Compaction
> Reporter: Marcus Eriksson
> Assignee: Lerh Chuan Low
> Labels: lhf
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> If a fully expired sstable is larger than the remaining disk space we won't
> run the compaction that can drop the sstable (ie, in our disk space check
> should not include the fully expired sstables)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
