[
https://issues.apache.org/jira/browse/CASSANDRA-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049666#comment-16049666
]
Jeff Jirsa commented on CASSANDRA-13603:
----------------------------------------
|| Branch || Testall || Dtest ||
| [3.0|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.0-13603] |
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-13603] |
[asf
dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/88/]
|
| [3.11|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.11-13603] |
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-13603]
| [asf
dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/89/]
|
| [trunk|https://github.com/jeffjirsa/cassandra/tree/cassandra-13603] |
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-13603] |
[asf
dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/90/]
|
For the reviewer: I really have mixed feelings about
{{MerkleTree.differenceHelper}} in general. In particular, it presumes that
there are differences in the trees, which is always true in the existing
codepath, but may not be true later if someone misuses it in the future. It
seems [fairly
straightforward|https://github.com/jeffjirsa/cassandra/commit/cee5a2d75e8e867dc20f3d94f0fe5df360210d46]
to make it properly handle the case where the trees are consistent for a given
range, though I'm not sure it's necessary.
Thoughts [[email protected]] / [~bdeggleston] ?
> Change repair midpoint logging from CASSANDRA-13052
> ----------------------------------------------------
>
> Key: CASSANDRA-13603
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13603
> Project: Cassandra
> Issue Type: Bug
> Components: Streaming and Messaging
> Reporter: Jeff Jirsa
> Assignee: Jeff Jirsa
> Priority: Trivial
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> In CASSANDRA-13052 , we changed the way we handle repairs on small ranges to
> make them more sane in general, but {{MerkleTree.differenceHelper}} now
> erroneously logs at error.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
