[
https://issues.apache.org/jira/browse/CASSANDRA-13603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057292#comment-16057292
]
Stefan Podkowinski commented on CASSANDRA-13603:
------------------------------------------------
We should continue to check the midpoint return value. Even if it's just for
troubleshooting similar problems in the future.
Throwing an AssertionError instead of just logging an error message is probably
not a good idea in 2.2. See my comment from before the patch:
{quote}Unfortunately we can't throw here to abort the validation process, as
the code is executed in it's own thread with the caller waiting for a condition
to be signaled after completion and without an option to indicate an error (2.x
only).
{quote}
But 3.0+ should be able to deal with failed SyncTasks, as those are now handled
as futures. SyncTask.run is currently missing any exception handling, but that
could be changed.
> Change repair midpoint logging from CASSANDRA-13052
> ----------------------------------------------------
>
> Key: CASSANDRA-13603
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13603
> Project: Cassandra
> Issue Type: Bug
> Components: Streaming and Messaging
> Reporter: Jeff Jirsa
> Assignee: Jeff Jirsa
> Priority: Trivial
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> In CASSANDRA-13052 , we changed the way we handle repairs on small ranges to
> make them more sane in general, but {{MerkleTree.differenceHelper}} now
> erroneously logs at error.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
