[
https://issues.apache.org/jira/browse/CASSANDRA-13614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055459#comment-16055459
]
Andrés de la Peña commented on CASSANDRA-13614:
-----------------------------------------------
Excellent suggestions:
bq. Can you add a notice to the nodetool command help stating that {{This will
be reduced proportionally to the number of nodes in the cluster}}, similar to
the YAML notice.
Done
[here|https://github.com/adelapena/cassandra/commit/c4431afc3c3e6fd598a3c0be9292f75868259141].
bq. Also, perhaps you could add a debug log on {{BatchLogManager.setRate}}
stating the actual rate that is being set, given it varies with the number of
nodes.
Done
[here|https://github.com/adelapena/cassandra/commit/1ef3e3bbd6e272e2d2f34fd734dbf4629e762a90].
I have only logged the effective change, do you think it is enough? I have
also updated the
[dtest|https://github.com/adelapena/cassandra-dtest/commit/360ae39190028397f4760734deca0ceb792ad071]
to check the log message.
bq. I think we should also include the {{nodetool getbatchlogreplaythrottlekb}}
command as well given the JMX method is already there so the extra effort is
minimum and could be handy for admins. I see there are some setters without
their corresponding getters on nodetool, but I think we should always include
both setters and getters. WDYT?
Makes sense, done
[here|https://github.com/adelapena/cassandra/commit/9620273dde5737a00b7d9742621068822f49502b].
Now that we have a nodetool command to read the set throttle, I have split the
dtest in one test for nodetool and other for JMX,
[here|https://github.com/adelapena/cassandra-dtest/commit/832fcb5a443d759e682aaaab01aadb15fd106b79].
Here is the full patch with the CI results:
||[trunk|https://github.com/apache/cassandra/compare/trunk...adelapena:13614-trunk]|[utests|http://cassci.datastax.com/view/Dev/view/adelapena/job/adelapena-13614-trunk-testall/]|[dtests|http://cassci.datastax.com/view/Dev/view/adelapena/job/adelapena-13614-trunk-dtest/]|
> Batchlog replay throttle should be dynamically configurable with jmx and
> possibly nodetool
> ------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-13614
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13614
> Project: Cassandra
> Issue Type: Sub-task
> Components: Configuration, Materialized Views
> Reporter: Andrés de la Peña
> Assignee: Andrés de la Peña
>
> As it is said in
> [CASSANDRA-13162|https://issues.apache.org/jira/browse/CASSANDRA-13162],
> batchlog replay can be excessively throttled with materialized views. The
> throttle is controlled by the property {{batchlog_replay_throttle_in_kb}},
> which is set by default to (only) 1024KB, and it can't be configured
> dynamically. It would be useful to be able of modifying it dynamically with
> JMX and possibly nodetool.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
