[
https://issues.apache.org/jira/browse/CASSANDRA-13614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068323#comment-16068323
]
Andrés de la Peña commented on CASSANDRA-13614:
-----------------------------------------------
I took {{sethintedhandoffthrottlekb}} as reference, but I also prefer not
including the time unit in the nodetool command name for consistency and
conciseness. I have changed it
[here|https://github.com/adelapena/cassandra/commit/c8c24377b67672d289edfd302b0c48141dd89b40],
full patch
[here|https://github.com/apache/cassandra/compare/trunk...adelapena:13614-trunk].
Taking {{get/setcompactionthroughput}} as reference, I have only changed the
{{get/setbatchlogreplaythrottle}} command names and the methods at
{{NodeProbe}}, the config property itself and other methods keep the unit in
the name.
Updated dtests can be found
[here|https://github.com/riptano/cassandra-dtest/compare/master...adelapena:CASSANDRA-13614].
I ran the updated patch on our internal CI. There are not failures for the unit
tests and the failing dtests are not related to the change.
About naming consistency, {{get/sethintedhandoffthrottlekb}} uses the term
"throttle" for what I think is the same concept which "throughput" alludes to
in {{get/setcompactionthroughput}} and others. I think I prefer "throttle",
although we probably don't want to change config property names at this point.
> Batchlog replay throttle should be dynamically configurable with jmx and
> possibly nodetool
> ------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-13614
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13614
> Project: Cassandra
> Issue Type: Sub-task
> Components: Configuration, Materialized Views
> Reporter: Andrés de la Peña
> Assignee: Andrés de la Peña
>
> As it is said in
> [CASSANDRA-13162|https://issues.apache.org/jira/browse/CASSANDRA-13162],
> batchlog replay can be excessively throttled with materialized views. The
> throttle is controlled by the property {{batchlog_replay_throttle_in_kb}},
> which is set by default to (only) 1024KB, and it can't be configured
> dynamically. It would be useful to be able of modifying it dynamically with
> JMX and possibly nodetool.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
