[
https://issues.apache.org/jira/browse/CASSANDRA-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086265#comment-16086265
]
Blake Eggleston commented on CASSANDRA-13688:
---------------------------------------------
Pushed up fix for that
[here|https://github.com/bdeggleston/cassandra/commit/994f2afe3f42811b1ebf64e3f6de9c14a3b7a28d].
Just for posterity, the problem being fixed here is that {{submitIfRunning}}
will return a cancelled future if the executor is shutdown. However, we weren't
checking the returned future, we were checking the submitted task, which
shouldn't ever be cancelled.
[new utests| https://circleci.com/gh/bdeggleston/cassandra/73]
[dtests|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/125/]
> Anticompaction race can leak sstables/txn
> -----------------------------------------
>
> Key: CASSANDRA-13688
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13688
> Project: Cassandra
> Issue Type: Bug
> Reporter: Blake Eggleston
> Assignee: Blake Eggleston
> Fix For: 4.0
>
>
> At the top of {{CompactionManager#performAntiCompaction}}, the parent repair
> session is loaded, if the session can't be found, a RuntimeException is
> thrown. This can happen if a participant is evicted after the IR prepare
> message is received, but before the anticompaction starts. This exception is
> thrown outside of the try/finally block that guards the sstable and lifecycle
> transaction, causing them to leak, and preventing the sstables from ever
> being removed from View.compacting.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
