[ 
https://issues.apache.org/jira/browse/CASSANDRA-14002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244696#comment-16244696
 ] 

Michael Kjellman commented on CASSANDRA-14002:
----------------------------------------------

So +1 from me. Comments look good and I don't even see any code style related 
nits. 50% faster is a bigger win than I expected when I saw it in profiling a 
long long long time ago to be honest... so that's super awesome news! 

Looks like a few repair related dtests did fail but looking at stdout it seems 
that this is weirdness with the Apache Jenkins instance and ccm not starting 
instances cleanly and not any fallout from this change.

> Don't use SHA256 when building merkle trees
> -------------------------------------------
>
>                 Key: CASSANDRA-14002
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14002
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 4.x
>
>
> We should avoid using SHA-2 when building merkle trees as we don't need a 
> cryptographic hash function for this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to